Skip to content

chore(tests): move integration tests to a separate crate#497

Merged
vladimirvolek merged 8 commits intomainfrom
chore/separate-test-crate
Mar 26, 2026
Merged

chore(tests): move integration tests to a separate crate#497
vladimirvolek merged 8 commits intomainfrom
chore/separate-test-crate

Conversation

@michalrus
Copy link
Copy Markdown
Member

@michalrus michalrus commented Mar 25, 2026

Context

In preparation for the upcoming end-to-end (E2E) tests between the Gateway and the Platform.

I'd like this second upcoming PR to have a smaller diff that just adds new tests.

We weren’t running Gateway tests!

After the subtree merge of Gateway into this monorepo in:

… it turns out we stopped running the Gateway tests, because their file name did not include the _test.rs suffix!

These tests were also failing after the update of Axum from 0.7 to 0.8, which changed the path segment capture format, see https://github.com/blockfrost/blockfrost-platform/actions/runs/23552254822/job/68570410736:

thread 'test_websocket_request_response_flow' (418964) panicked at crates/integration_tests/src/gateway/mod.rs:13:10:
Path segments must not start with `:`. For capture groups, use `{capture}`. If you meant to literally match a segment starting with a colon, call `without_v07_checks` on the router.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

These issues have also been corrected by this PR.

Now, we’re running all tests under crates/integration-tests/, regardless of their name.

Review

Since there's been white space changes coupled with file renames, it’s better to review the first two commits first, and then just the last commit with "hide white space" enabled:

  1. main...6e60c82
  2. 6e60c82...pull/497/head

@michalrus michalrus self-assigned this Mar 25, 2026
@michalrus michalrus added the enhancement New feature or request label Mar 25, 2026
@michalrus michalrus added this to the v1 milestone Mar 25, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 25, 2026

Deploying blockfrost-platform with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40d9494
Status: ✅  Deploy successful!
Preview URL: https://7087fd16.blockfrost-platform.pages.dev
Branch Preview URL: https://chore-separate-test-crate.blockfrost-platform.pages.dev

View logs

@michalrus michalrus marked this pull request as draft March 25, 2026 16:31
@michalrus michalrus marked this pull request as ready for review March 25, 2026 16:44
@vladimirvolek vladimirvolek merged commit c6a5857 into main Mar 26, 2026
38 of 39 checks passed
@michalrus michalrus deleted the chore/separate-test-crate branch March 26, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants