Merged
Conversation
Deploying blockfrost-platform with
|
| Latest commit: |
add650f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://576b1ab6.blockfrost-platform.pages.dev |
| Branch Preview URL: | https://tracing-manual.blockfrost-platform.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates logging across platform/gateway/node crates to rely on tracing targets (instead of manual log prefixes) and adjusts CI job structure to run static checks before builds/tests.
Changes:
- Enable
.with_target(true)in tracing subscriber formatting to include log targets. - Remove manual log message prefixes (e.g.,
load balancer:,IceBreakers:,FallbackDecoder:) and add structuredconnection_idfields in node logs. - Rename CI Docker lint job to
static_checksand make key jobs depend on it.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/platform/src/server/logging.rs | Enable tracing targets in platform log formatting. |
| crates/platform/src/load_balancer.rs | Remove manual "load balancer:" prefixes from load balancer logs. |
| crates/platform/src/icebreakers/manager.rs | Remove manual "IceBreakers:" log prefixes. |
| crates/platform/src/icebreakers/api.rs | Remove manual "load balancer:" prefix from fallback URI log line. |
| crates/node/src/transactions.rs | Replace manual N2C[...] prefix with structured connection_id field in logs. |
| crates/node/src/pool_manager.rs | Replace manual N2C[...] prefix with connection_id field in logs. |
| crates/node/src/connection.rs | Replace manual N2C[...] prefix with structured connection_id field in logs. |
| crates/node/src/cbor/fallback_decoder.rs | Remove manual FallbackDecoder: prefixes from errors and panic messages. |
| crates/gateway/src/main.rs | Enable tracing targets in gateway log formatting. |
| crates/gateway/src/load_balancer.rs | Remove manual "load balancer:" prefixes from gateway load balancer logs. |
| .github/workflows/ci.yaml | Consolidate linting/formatting/clippy into static_checks and update job dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
Not 100% I think. |
michalrus
added a commit
that referenced
this pull request
Apr 2, 2026
michalrus
added a commit
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #479