feat(CIP68): conversion of additional/unknown string props to UTF8#60
Draft
slowbackspace wants to merge 2 commits intomasterfrom
Draft
feat(CIP68): conversion of additional/unknown string props to UTF8#60slowbackspace wants to merge 2 commits intomasterfrom
slowbackspace wants to merge 2 commits intomasterfrom
Conversation
slowbackspace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #59
Adds conversion of additional/unknown top-level string metadata props to UTF8.
Note that this change affect only top-level prop (see added test fixture) and and all primitive data types except strings will continue to be encoded in CBOR hexadecimal format (CIP68 talks only about converting string entries). However maybe we should convert all primitive values (such as numbers, booleans, null) found within additional/unknown props.
Implemented as non-breaking change in the lib. New behaviour can be enabled by passing an option param
convertAdditionalPropsToUTF8: truetogetMetadataFromOutputDatumfn. However, once it is enabled on Blockfrost backends it will be a breaking change. To prevent chaos we probably want to introduce this change in a new metadata endpoint.