Conversation
07cbc3d to
87c6cef
Compare
87c6cef to
d952fef
Compare
You can run We should add a CI check for that, I'll do it. |
michalrus
left a comment
There was a problem hiding this comment.
A very initial review without the most important 2 files (Encoder and Evaluation):
|
CI checks for code formatting added in e4f97d9. You can auto-format everything locally by running |
michalrus
left a comment
There was a problem hiding this comment.
The 2nd part of the review:
|
After merging this, we'll have to make a (pre)release, because the |
Formating done in b0db0e1 |
michalrus
left a comment
There was a problem hiding this comment.
LGTM! And CI is green. Let’s merge.
Now we need to release this.
I'm also worried about updates to be based on the latest cardano-node, but we’ll see.
Ready for the first review.
Please note that, I couldn't 'format' the code with any tools since I had no IDE or tool support. I did only use
nix build -LRust part: blockfrost/blockfrost-platform#322