Skip to content

Implemented eval tx stream#3

Merged
michalrus merged 10 commits intomainfrom
feat/eval-stream
Feb 12, 2026
Merged

Implemented eval tx stream#3
michalrus merged 10 commits intomainfrom
feat/eval-stream

Conversation

@ginnun
Copy link
Copy Markdown
Collaborator

@ginnun ginnun commented Aug 26, 2025

Ready for the first review.

Please note that, I couldn't 'format' the code with any tools since I had no IDE or tool support. I did only use nix build -L

Rust part: blockfrost/blockfrost-platform#322

@michalrus
Copy link
Copy Markdown
Member

Please note that, I couldn't 'format' the code with any tools since I had no IDE or tool support. I did only use nix build -L

You can run nix fmt, the formatters for all languages in this repo are set up in flake.nix :)

We should add a CI check for that, I'll do it.

Copy link
Copy Markdown
Member

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very initial review without the most important 2 files (Encoder and Evaluation):

@michalrus
Copy link
Copy Markdown
Member

michalrus commented Jan 20, 2026

CI checks for code formatting added in e4f97d9.

You can auto-format everything locally by running nix fmt in the repo, there will be a few changes:

❯ git diff --stat

 testgen-hs/Encoder.hs       | 525 ++++++++++----------
 testgen-hs/Evaluation.hs    |  98 ++--
 testgen-hs/Generators.hs    |   6 +-
 testgen-hs/Main.hs          |  74 +--
 testgen-hs/Response.hs      |   6 +-
 testgen-hs/SynthEvalTx.hs   |   4 +-
 testgen-hs/testgen-hs.cabal |  18 +-

 7 files changed, 362 insertions(+), 369 deletions(-)

Copy link
Copy Markdown
Member

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2nd part of the review:

@michalrus
Copy link
Copy Markdown
Member

After merging this, we'll have to make a (pre)release, because the blockfrost-platform PR depends on this binary. 📝

@ginnun
Copy link
Copy Markdown
Collaborator Author

ginnun commented Jan 26, 2026

CI checks for code formatting added in e4f97d9.

You can auto-format everything locally by running nix fmt in the repo, there will be a few changes:

❯ git diff --stat

 testgen-hs/Encoder.hs       | 525 ++++++++++----------
 testgen-hs/Evaluation.hs    |  98 ++--
 testgen-hs/Generators.hs    |   6 +-
 testgen-hs/Main.hs          |  74 +--
 testgen-hs/Response.hs      |   6 +-
 testgen-hs/SynthEvalTx.hs   |   4 +-
 testgen-hs/testgen-hs.cabal |  18 +-

 7 files changed, 362 insertions(+), 369 deletions(-)

Formating done in b0db0e1

Copy link
Copy Markdown
Member

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And CI is green. Let’s merge.

Now we need to release this.

I'm also worried about updates to be based on the latest cardano-node, but we’ll see.

@michalrus michalrus merged commit e7fd2b0 into main Feb 12, 2026
3 checks passed
@michalrus michalrus deleted the feat/eval-stream branch February 12, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants