Modify _get_digest to use request.get_data().#23
Open
ahawad wants to merge 7 commits intobloomberg:masterfrom
Open
Modify _get_digest to use request.get_data().#23ahawad wants to merge 7 commits intobloomberg:masterfrom
ahawad wants to merge 7 commits intobloomberg:masterfrom
Conversation
* request.data is empty when the request type is application/x-www-form-urlencoded * request.get_data contains the raw request bytes, cached by flask, and that works for both application/json and application/x-www-form-urlencoded Signed-Off-By: Ahmed Awad <ahmed.awad.15@ucl.ac.uk>
|
Am I correct in thinking that this would fix webhook secrets for |
|
@alexchamberlain Verification of secrets with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a follow on to commit 8d3ad24:
request.data is empty when the content type of the payload is application/x-www-form-urlencoded, because the payload is parsed by Flask into request.form.
request.get_data() contains the contents of the request body that Flask cached. This works for application/json as well, because GitHub computes the signature over the request body in both cases.
Testing performed
I have tested this manually by issuing Github Webhooks to a local development server.