Send json list of data returned from hooks#31
Open
nickadam wants to merge 1 commit intobloomberg:masterfrom
Open
Send json list of data returned from hooks#31nickadam wants to merge 1 commit intobloomberg:masterfrom
nickadam wants to merge 1 commit intobloomberg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #18
Describe your changes
Changes response from 204 to 200 with a json list of data returned from hooks. The hooks' return data shows up in Recent Deliveries body.
Testing performed
Tested on github.com with hooks that do not have a return or return JSON serializable data
Additional context
If a hook returns content that is not JSON serializable it will throw an error