Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

initial commit#201

Open
AKolumbic wants to merge 5 commits intobloominstituteoftechnology:masterfrom
AKolumbic:master
Open

initial commit#201
AKolumbic wants to merge 5 commits intobloominstituteoftechnology:masterfrom
AKolumbic:master

Conversation

@AKolumbic
Copy link

No description provided.

-still need to add comments
@AKolumbic
Copy link
Author

my queue isn't passing, and I'm having trouble figuring out why. I've gone over the solution code, and as far as I can tell theres no errors. I am getting errors pointing to this line: this.processess.splice(sourceIndex, 1);
TypeError: Cannot read property 'splice' of undefined

-queue is passing now, I had a typo
-Scheduler is having weird behavior with the break[ln 46]
-test won't run with it, but fails because its not there when removed
-im leaving it commented out to show its the only failing test
@AKolumbic
Copy link
Author

I am basically finished with the retyping of the code. I fixed the issue with the earlier comment, about the splice. I misspelt 'processes', as you can see in the comment above. Currently Scheduler is not passing, and I am unsure why. This time it doesn't seem to be a typo. There is a break; statement that if I understand correctly, breaks out of the allQueuesEmpty() loop, and the break; causes the tests to not even run if it is included, however if I comment it out, the tests will all pass, save for the last one, ✕ run method runs until all processes have completed execution (9ms) which I am pretty sure that is failing because it is now stuck in that loop and not breaking out. Not sure whats up with that, but I am now starting the Q&A, since Sean is going through what the process exercises are doing, that will help with the comments.

@emukupa
Copy link

emukupa commented Aug 24, 2018

Great Job andrew. You are putting the necessary work needed. Am loving it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants