Skip to content

Update feature detection to use target_has_atomic#5

Open
lscorcia wants to merge 4 commits intobltavares:masterfrom
lscorcia:patch-1
Open

Update feature detection to use target_has_atomic#5
lscorcia wants to merge 4 commits intobltavares:masterfrom
lscorcia:patch-1

Conversation

@lscorcia
Copy link
Copy Markdown

@lscorcia lscorcia commented Sep 12, 2022

Rust 1.60 stabilized the target_has_atomic cfg, adopt it to use the shim on all platforms that require it (e.g. armv5te and more). Fixes #4.

Rust 1.60 stabilized the target_has_atomic cfg, adopt it to use the shim on all platforms that require it (e.g. armv5el and more)
@bltavares
Copy link
Copy Markdown
Owner

Hello there, thanks for the PR. There are still a few features to be considered as part of the cfg shim.

I'm not having personal time to dedicate to it at this moment to take a look at this right now.
If you would like, try adding the cfg() for the mutex feature, so other crates can enable the shimmer even on supported platforms if they need to validate it without cross-compiling.

The rust 1.60 should not be needed as well, as it's a shim we should be able to support older versions of rust.

@lscorcia
Copy link
Copy Markdown
Author

Sorry, I don't have the required rust knowledge to complete this work. The issue I had originally was with the indicatif crate, which has now been updated to use https://github.com/taiki-e/portable-atomic . Feel free to close the PR if you feel so, I already closed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional ARM platform support

2 participants