perf: wire shared stack arena into frame creation #3399
Open
malik672 wants to merge 22 commits intobluealloy:mainfrom
Open
perf: wire shared stack arena into frame creation #3399malik672 wants to merge 22 commits intobluealloy:mainfrom
malik672 wants to merge 22 commits intobluealloy:mainfrom
Conversation
Merging this PR will improve performance by 4.44%
Performance Changes
Comparing |
7437435 to
1f6238d
Compare
Contributor
Author
|
|
Contributor
Author
|
clearly the benchmark might not show it but a significant number of txs on mainnet are type 2 |
53b2d84 to
730299c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads the pre-allocated arena buffer
(Arc<Vec<U256>>)from Evm through the frame creation chain. NestedCALL/CREATEframes now useStack::new_with_arenainstead of allocating a fresh Vec per frame.