Skip to content

Conversation

@nputnam
Copy link
Contributor

@nputnam nputnam commented Dec 17, 2025

Hello. I've made some updates to the dependencies and fixed a bug. Happy to address any feedback you have. I've been running this build in my lab network for a week now without issue. DDNS updates are working with a DNS server that was previously getting it's updates from Kea.

Change log :

  • Update to from trust to hickory-dns
  • Update Rust to 1.91.0
  • Update dhcproto to 0.14.0
  • Fix bug in reading tsig key from config. The bytes weren't being converted from Base64 before use in Hickory.
  • Address TODO using V6 Htype.

* Update Rust to 1.91.0
* Update dhcproto to 0.14.0
* Fix bug in reading tsig key from config.
@leshow
Copy link
Collaborator

leshow commented Dec 18, 2025

Thank you! Great to hear about the ddns updates.

@coveralls
Copy link
Collaborator

coveralls commented Dec 18, 2025

Coverage Status

coverage: 68.824% (+0.6%) from 68.268%
when pulling 8738979 on nputnam:ddns-lib-updates
into 7337319 on bluecatengineering:master.

@leshow
Copy link
Collaborator

leshow commented Dec 18, 2025

This is great, thank you for catching that bug and trying this out.

@nputnam
Copy link
Contributor Author

nputnam commented Dec 18, 2025

This is great, thank you for catching that bug and trying this out.

Thanks for the review. I'll keep an eye on the actions and fix anything that keeps the build from passing. Hopefully I addressed all your feedback.

@leshow
Copy link
Collaborator

leshow commented Dec 19, 2025

I made some minor changes with the logging to put some more lines at the trace level and some tracing spans so its easier to read the log if multiple updates happen concurrently.

Copy link
Collaborator

@leshow leshow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks again!

@leshow leshow merged commit 29392f7 into bluecatengineering:master Dec 19, 2025
6 checks passed
@leshow
Copy link
Collaborator

leshow commented Dec 19, 2025

If you have the time to give this a go again and verify it's working, let me know. You might need to set logs to debug to see the same output.

If you're interested in more, we could use tests, unit tests in ddns to verify the messages are constructed properly and a component test in bin/tests as a kind of sanity check. No pressure.

@nputnam
Copy link
Contributor Author

nputnam commented Dec 20, 2025

I've been running the update since this morning and ddns stuff is working for me. I'll look at adding some tests in the next couple weeks. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants