-
Notifications
You must be signed in to change notification settings - Fork 21
Update hickory-dns and dhcproto dependencies #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update Rust to 1.91.0 * Update dhcproto to 0.14.0 * Fix bug in reading tsig key from config.
|
Thank you! Great to hear about the ddns updates. |
|
This is great, thank you for catching that bug and trying this out. |
Thanks for the review. I'll keep an eye on the actions and fix anything that keeps the build from passing. Hopefully I addressed all your feedback. |
|
I made some minor changes with the logging to put some more lines at the trace level and some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks again!
|
If you have the time to give this a go again and verify it's working, let me know. You might need to set logs to debug to see the same output. If you're interested in more, we could use tests, unit tests in ddns to verify the messages are constructed properly and a component test in bin/tests as a kind of sanity check. No pressure. |
|
I've been running the update since this morning and ddns stuff is working for me. I'll look at adding some tests in the next couple weeks. Thanks! |
Hello. I've made some updates to the dependencies and fixed a bug. Happy to address any feedback you have. I've been running this build in my lab network for a week now without issue. DDNS updates are working with a DNS server that was previously getting it's updates from Kea.
Change log :