Include more context when subprocess fails #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a catalog adapter, a subprocess is used to initialise the
database, if this process fails, the error (written to stderr) was lost
making it difficult to determine the cause.
By wrapping the stderr in a new exception and setting it to be the cause
of the raised CalledProcessException, Python displays it as
<subprocess stderr content>
The above exception was the direct cause of the following exception:
<the stacktrace of the command being run as before>
and the cause is more clearly visible.
tpoliaw
force-pushed
the
init_error_context
branch
from
9f75960 to
e11a8cf
Compare
danielballan
approved these changes
Jan 6, 2026
Member
danielballan
left a comment
danielballan
left a comment
There was a problem hiding this comment.
Nice technique! Hadn't seen this approach before.
Contributor
Author
|
Neither had I and there might be a good reason not to do it but it makes debugging much easier. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a catalog adapter, a subprocess is used to initialise the
database. If this process fails, the error (written to stderr) was lost
making it difficult to determine the cause.
By wrapping the stderr in a new exception and setting it to be the cause
of the raised CalledProcessException, Python displays it as
and the cause is more clearly visible.