Issue 797: Created a seperate markdown for before the waiver is available so link is not shown #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able so link is not shown
srisainachuri
requested changes
Jun 29, 2022
Contributor
srisainachuri
left a comment
srisainachuri
left a comment
There was a problem hiding this comment.
Some minor things to look at, but overall logic looks good! Let's also look into why the integration tests are failing before merging
| # Copyright (c) 2011-2022 Berkeley Model United Nations. All rights reserved. | ||
| # Use of this source code is governed by a BSD License (see LICENSE). | ||
| SESSION = 70 | ||
| SESSION = 69 |
Contributor
There was a problem hiding this comment.
Let's remove this from commit, since I assume locally you had to use 69. Our prod is on 70 right now
| "less-loader": "^7.2.1", | ||
| "markdown-loader": "^6.0.0", | ||
| "mini-css-extract-plugin": "^1.3.3", | ||
| "mini-css-extract-plugin": "^1.6.2", |
Contributor
There was a problem hiding this comment.
Was there a specific reason this version upgrade was needed? If it doesn't affect functionality and passes the unit tests, it should be fine though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in logic to check if the waiver is already available based on the waiver's availability date. Displays the appropriate text, only showing the waiver link if it is past the date that the waiver is available.