fix for SSLError - new arg --verify <CA_BUNDLE>#348
Open
c-w-m wants to merge 7 commits intobndr:masterfrom
Open
fix for SSLError - new arg --verify <CA_BUNDLE>#348c-w-m wants to merge 7 commits intobndr:masterfrom
--verify <CA_BUNDLE>#348c-w-m wants to merge 7 commits intobndr:masterfrom
Conversation
Collaborator
|
Thanks also for this PR! What do you think, should we still add this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSLError #346 final
implementation of new arg (--verify <CA_BUNDLE> to allow requests.get setting of verify arg
testing updates
dotnetused with testing to allow.env.testfile for setting CA_BUNDLE environment variabletests_requirementsto setup.py to support$ python setup.py testrequirements-dev.txtto support development (includes black for formatting)settings.pyfile used in testing to read in either environment variable or .env.test variablepython-version: [3.7, 3.8, 3.9, pypy-3.7])doc updates
--verifyoptionfinal tox runs attached
.vscode directory added (it can be ignored if not of interest, my bad)
Cheers
last bit/suggestion
CONTRIBUTING.rstwith note on setting CA_BUNDLE if needed (see below)When you're done making changes, check that your changes pass flake8 and the tests, including testing other Python versions with tox::
$ flake8 pipreqs tests > flake8_pipreqs_tests_results.txt
if needed, set the CA_BUNDLE value in the
.env.testfile located in tests/ (or set an environment variable)$ python setup.py test > python_setup_tests_pipreqs_results.txt
$ tox > tox_pipreqs_results.txt