Added debug message to describe decode failures discussed in issue 214#439
Open
KyleLuoma wants to merge 1 commit intobndr:masterfrom
Open
Added debug message to describe decode failures discussed in issue 214#439KyleLuoma wants to merge 1 commit intobndr:masterfrom
KyleLuoma wants to merge 1 commit intobndr:masterfrom
Conversation
…4. Exception handler cathes generic Exception objects, logs a debug message including the culprit filename, and then raises the exception.
|
This looks like an improvement over the current situation. I wonder if files like these should just be ignorned and the code moves on to the next one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this exception handler to deal with #214 which, although closed, can still cause grief if the user is not able to ignore sub directories that contain the culprit file. This does not resolve the decode error; but it provides an additional debug statement that names the file causing the error.