Add support for scanning imports in specified virtual environments, fix #434#445
Open
Tdarnell wants to merge 2 commits intobndr:masterfrom
Open
Add support for scanning imports in specified virtual environments, fix #434#445Tdarnell wants to merge 2 commits intobndr:masterfrom
Tdarnell wants to merge 2 commits intobndr:masterfrom
Conversation
Author
|
This is in relation to issue #434 |
Collaborator
|
Hi @Tdarnell , thanks a lot for the PR. I understand the issue, however, I am not sure if this is the best way to go about it. I agree that the version should match the installed version if somehow possible, but this rather fixes a special case. What about conda envs for example? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a argument "--venv" which looks for imports in only specified folders, defaults to sys.path when this is not given