Avoid test/tests folder to ignore the file encoding issue, beasuse so…#467
Open
EircYangQM wants to merge 1 commit intobndr:masterfrom
Open
Avoid test/tests folder to ignore the file encoding issue, beasuse so…#467EircYangQM wants to merge 1 commit intobndr:masterfrom
EircYangQM wants to merge 1 commit intobndr:masterfrom
Conversation
…me package like IPython, joblib use the other encoding file for testing.
Collaborator
|
Hm, I think this isn't just an encoding issue but rather a breaking change as the test/tests folder will be ignored, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid test/tests folder to ignore the file encoding issue, beasuse some package like IPython, joblib use the other encoding file for testing.