Open
Conversation
Collaborator
alan-barzilay
left a comment
There was a problem hiding this comment.
its been a while since I handled this codebase, but pretty sure pipreqs can be run with an individual file as a target so this would throw an error in a legitimate use case.
Also, the project is a bit abandoned but we previously had a policy of requiring tests for any changes and new features. I dont think there are new maintainers but even if there are they may not follow this policy anymore. Do with this information what you will, sorry I cant be a bigger help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds error handling for the case when the user provides a file instead of a directory.
Example:
Current version
pipreqs project/main.py:This fork
pipreqs project/main.py:ERROR: The path 'project/main.py' is not a directory. Please provide a directory path.Testing
This works properly in my tests.
Question
Is this section in contributing guideline optional?:
Thanks!