fix: improve --ignore-errors handling for notebook and syntax errors#518
Open
KushalLukhi wants to merge 1 commit intobndr:masterfrom
Open
fix: improve --ignore-errors handling for notebook and syntax errors#518KushalLukhi wants to merge 1 commit intobndr:masterfrom
KushalLukhi wants to merge 1 commit intobndr:masterfrom
Conversation
This PR addresses two related issues: Fixes bndr#485 - --ignore-errors flag not working with notebooks: - ipynb_2_py now catches exceptions and logs warnings - read_file_content raises ValueError when notebook parsing fails - Errors now properly propagate to the ignore_errors handler Fixes bndr#494 - SyntaxError with Python 2 syntax: - Added better SyntaxError handling in get_all_imports - Provides helpful warning message about Python 2 syntax - Suggests using --ignore-errors flag when SyntaxError occurs Changes: - Modified ipynb_2_py to catch exceptions and return None - Modified read_file_content to raise ValueError on notebook failures - Enhanced error handling in get_all_imports for syntax errors - Added tests for ignore_errors with invalid notebooks and Python 2 syntax Testing: - Added test_ignore_errors_with_invalid_notebook - Added test_ignore_errors_with_syntax_error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two related issues:
Fixes #485 - --ignore-errors flag not working with notebooks:
ipynb_2_py()now catches exceptions and logs warnings instead of crashingread_file_content()raises ValueError when notebook parsing failsget_all_imports()Fixes #494 - SyntaxError with Python 2 syntax:
get_all_imports()Changes:
ipynb_2_py()to catch exceptions and return Noneread_file_content()to raise ValueError on notebook failuresget_all_imports()for syntax errorsTesting:
test_ignore_errors_with_invalid_notebook()test_ignore_errors_with_syntax_error()Closes #485, #494