Add completed PropertyDescriptor type#5284
Open
HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
Open
Conversation
Test262 conformance changes
Fixed tests (2):Tested main commit: |
38fea6d to
40d9a5e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5284 +/- ##
===========================================
+ Coverage 47.24% 59.59% +12.35%
===========================================
Files 476 589 +113
Lines 46892 63663 +16771
===========================================
+ Hits 22154 37940 +15786
- Misses 24738 25723 +985 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
40d9a5e to
1594d05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors property descriptor handling by replacing the builder-style PropertyDescriptor with a more explicit
CompletePropertyDescriptorenum. This makes things clearer and more type-safe. The spec always stores complete property descriptors in objects.Since descriptors are always complete, this allows us to skip some checks and may allow the compiler to better optimize the code. Additionally this also reduces the memory usage for sparse generic arrays,
CompletePropertyDescriptoris 24 bytes vs.PropertyDescriptor40 bytes (64bit arch).