feat: implement Temporal.PlainMonthDay.prototype.toLocaleString#5285
Open
Cypher-CP0 wants to merge 1 commit intoboa-dev:mainfrom
Open
feat: implement Temporal.PlainMonthDay.prototype.toLocaleString#5285Cypher-CP0 wants to merge 1 commit intoboa-dev:mainfrom
Temporal.PlainMonthDay.prototype.toLocaleString#5285Cypher-CP0 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Signed-off-by: Cypher-CP0 <prabhatu4559@gmail.com>
Cypher-CP0
requested review from
jasonwilliams,
jedel1043 and
nekevss
as code owners
github-actions
bot
added
the
Waiting On Review
github-actions
bot
added
C-Builtins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5085.
It changes the following:
Temporal.PlainMonthDay.prototype.toLocaleStringinplain_month_day/mod.rs, replacing the previous stub that ignoredlocalesandoptionsarguments and fell back totoString()format_plain_month_day_localeinintl/date_time_format/mod.rs, a new helper that formats aPlainMonthDayusing ICU4X directly from month/day fields (using the Temporal spec's reference year 1972) instead of going through the Unix timestamp path used byDate{ month: "long", day: "numeric" }when nodateStyle,month, ordayoptions are provided, matching ECMA-402ToDateTimeOptionsbehaviour for date formatting