Modify boa_runtime's timers to use native timeout tracking and cancellation#5289
Open
jedel1043 wants to merge 3 commits intoboa-dev:mainfrom
Open
Modify boa_runtime's timers to use native timeout tracking and cancellation#5289jedel1043 wants to merge 3 commits intoboa-dev:mainfrom
jedel1043 wants to merge 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5289 +/- ##
===========================================
+ Coverage 47.24% 59.74% +12.49%
===========================================
Files 476 589 +113
Lines 46892 63591 +16699
===========================================
+ Hits 22154 37992 +15838
- Misses 24738 25599 +861 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the timer code in
boa_runtimesuch that it uses the recently introducedCancellationToken.It also removes usages of
Rc<RefCell<>>, which are replaces by directly querying the context for a timeout tracker, making it possible to extract a&mut IntervalInnerStatefrom it`.Finally a couple of cleanups and renames here and there