Skip to content

Modify boa_runtime's timers to use native timeout tracking and cancellation#5289

Open
jedel1043 wants to merge 3 commits intoboa-dev:mainfrom
jedel1043:native-timeouts
Open

Modify boa_runtime's timers to use native timeout tracking and cancellation#5289
jedel1043 wants to merge 3 commits intoboa-dev:mainfrom
jedel1043:native-timeouts

Conversation

@jedel1043
Copy link
Copy Markdown
Member

This modifies the timer code in boa_runtime such that it uses the recently introduced CancellationToken.
It also removes usages of Rc<RefCell<>>, which are replaces by directly querying the context for a timeout tracker, making it possible to extract a &mut IntervalInnerState from it`.

Finally a couple of cleanups and renames here and there

@jedel1043 jedel1043 requested a review from a team as a code owner April 1, 2026 02:00
@github-actions github-actions bot added the Waiting On Review Waiting on reviews from the maintainers label Apr 1, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Apr 1, 2026
@github-actions github-actions bot added C-CLI Issues and PRs related to the Boa command line interface. C-Builtins PRs and Issues related to builtins/intrinsics C-Runtime Issues and PRs related to Boa's runtime features labels Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,735 50,735 0
Ignored 1,426 1,426 0
Failed 802 802 0
Panics 0 0 0
Conformance 95.79% 95.79% 0.00%

Tested main commit: f5e88de558e038f0ae675a012d59917a098f44b6
Tested PR commit: c8d01e1752c0224f027a5c44c3ef908fc1bb8888
Compare commits: f5e88de...c8d01e1

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 60.09615% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.74%. Comparing base (6ddc2b4) to head (c8d01e1).
⚠️ Report is 925 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/host_defined.rs 31.37% 35 Missing ⚠️
core/engine/src/job.rs 71.87% 27 Missing ⚠️
cli/src/executor.rs 0.00% 18 Missing ⚠️
core/engine/src/builtins/atomics/futex.rs 0.00% 2 Missing ⚠️
core/engine/src/context/mod.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5289       +/-   ##
===========================================
+ Coverage   47.24%   59.74%   +12.49%     
===========================================
  Files         476      589      +113     
  Lines       46892    63591    +16699     
===========================================
+ Hits        22154    37992    +15838     
- Misses      24738    25599      +861     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-CLI Issues and PRs related to the Boa command line interface. C-Runtime Issues and PRs related to Boa's runtime features Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant