Skip to content

sync(bfmono): fix(simulator-ui): prevent feedback reason text from being clobbered (+19 more) (bfmono@b4d5cdaef) #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bft-codebot merged 1 commit into from
Feb 25, 2026
Merged

sync(bfmono): fix(simulator-ui): prevent feedback reason text from being clobbered (+19 more) (bfmono@b4d5cdaef) #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions simulator-ui/src/shared.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,15 +320,23 @@ export function FeedbackControls(props: {
const [errorMessage, setErrorMessage] = useState<string | null>(null);
const requestSeqRef = useRef(0);

// Keep local draft in sync with persisted feedback, but never while the user
// is actively typing or a save is in flight, otherwise server echoes can
// clobber in-progress text and make the textarea feel flaky.
useEffect(() => {
setReason(feedback?.reason ?? "");
if (typeof feedback?.score === "number" || feedback?.reason !== undefined) {
setStatus("saved");
} else {
setStatus("idle");
const isEditing = status === "unsaved" || status === "saving";
if (!isEditing) {
setReason(feedback?.reason ?? "");
if (
typeof feedback?.score === "number" || feedback?.reason !== undefined
) {
setStatus("saved");
} else {
setStatus("idle");
}
setErrorMessage(null);
}
setErrorMessage(null);
}, [feedback?.reason, feedback?.score]);
}, [feedback?.reason, feedback?.score, status]);

useEffect(() => {
if (typeof feedback?.score === "number") {
Expand Down