Skip to content

Conversation

@benoitmonin
Copy link

Use a pattern rule for the agendas instead of a call to a sub-make, since the only prerequisite specific to an agenda can be expressed with a pattern.

This fixes the parallel generation of the prerequisites of the agendas.

Comparing the resulting pdfs with diff-pdf shows no difference.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tleb
Copy link
Member

tleb commented Nov 5, 2025

If you rebase on top of the master branch the CLA bot should retrigger and not complain anymore (31d6c1a).

Use a pattern rule for the agendas instead of a call to a sub-make,
since the only prerequisite specific to an agenda can be expressed with
a pattern.

This fixes the parallel generation of the prerequisites of the agendas.

Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
@tpetazzoni
Copy link
Contributor

This doesn't apply anymore since 8cc2671. Also, I'm not a big fan of the change in the first place as it breaks the pattern that we have for slides, labs and agendas. So if we want to avoid the sub-make, I'd prefer to avoid it for all cases, and not just for agendas.

@tpetazzoni tpetazzoni closed this Dec 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2025
@tleb
Copy link
Member

tleb commented Jan 5, 2026

The goal would indeed be to drop the sub-make pattern, but it is hard to do so for slides & agendas. Which is why a first good step is to only change agendas.

@tpetazzoni
Copy link
Contributor

Well, I don't have the same reasoning. Until we have an idea to avoid the sub-make for everything, I prefer keeping the sub-make for everything. Consistency first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants