Open
Conversation
Collaborator
|
Hi, thanks for the addition. I'm definitely interested in merging this. I just noticed that you adjusted the hooks to work with newer Borgmatic versions. Currently we are looking into supporting a few config versions at the same time, since not everyone can run the latest Borgmatic version, if they are installing from distro packages. Possible to leave the hook adjustments out for now and add the relevant code as comment in #145 so it can be used there? |
Collaborator
|
Thanks for the PR, but I'm afraid it does too many things. Much more than the title says. It even changes the config format. Not saying it's bad, just a big change. Also some TODOs left in the code. |
ADMIN-6044: add app_name
ADMIN-6028: added borg mount support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Rocky8 and Rocky9 with tests. Rocky8 require ansible<10 to run because of python3.6 in the distro.