Fix webpack config to include node:false#108
Open
richtera wants to merge 1 commit intoborisyankov:masterfrom
Open
Fix webpack config to include node:false#108richtera wants to merge 1 commit intoborisyankov:masterfrom
richtera wants to merge 1 commit intoborisyankov:masterfrom
Conversation
This was referenced Jan 20, 2018
Author
|
Will this be merged or do I have to stay on a custom fork with webpack? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not having node:false causes process shim to be included in the output which causes webpack to prevent DefinePlugin from replacing things like process.env.NODE_ENV in any module included after this one.