Open
Conversation
Signed-off-by: Luong Vu Nam <nam.luongvu@vn.bosch.com>
Signed-off-by: Luong Vu Nam <nam.luongvu@vn.bosch.com>
johannes-mueller
requested changes
Nov 11, 2025
Member
johannes-mueller
left a comment
johannes-mueller
left a comment
There was a problem hiding this comment.
General request: Please add unit tests to test the new behavior.
Comment on lines
+247
to
+256
| # element_types = {el.type for el in instance.elements} | ||
| # unsupported_types = {et for et in element_types if et[0] != "C"} | ||
| # if unsupported_types: | ||
| # raise ValueError( | ||
| # "Only continuum elements (C...) are supported at this point, sorry. " | ||
| # "Please submit an issue to https://github.com/boschresearch/pylife/issues " | ||
| # "if you need to support other types. " | ||
| # "(Unsupported types %s found in instance %s)" % ( | ||
| # ", ".join(unsupported_types), instance_name | ||
| # )) |
Member
There was a problem hiding this comment.
Isn't this code still needed? Do we really support all element types? We need to be sure about that. If yes we delete the code, not comment it.
| if stress_component not in response_values.columns: | ||
| response_values[stress_component] = 0.0 | ||
|
|
||
| return response_values |
Member
There was a problem hiding this comment.
How about other tensor variables like strain and force? Can we add those, too? Otherwise it would be like a half finished improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing stress components in order to directly calculate Stress Criteria, such as Von Mises, Tresca...