Skip to content

Conversation

@KarlisJ
Copy link
Contributor

@KarlisJ KarlisJ commented Oct 28, 2017

Added methods to fully test questions and FB templates

There are new tests written to see almost all new methods in action.

There will be a conflict with assertTemplate method. Currently it expects second (optional) parameter to be boolean $strict but in this PR it expects a closure. Old "strict" comparison was bad call because it actually does not differ from assertRaw.

@codecov
Copy link

codecov bot commented Oct 28, 2017

Codecov Report

Merging #15 into master will increase coverage by 6.46%.
The diff coverage is 73.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
+ Coverage     61.81%   68.27%   +6.46%     
- Complexity       73      141      +68     
============================================
  Files             7       12       +5     
  Lines           254      457     +203     
============================================
+ Hits            157      312     +155     
- Misses           97      145      +48
Impacted Files Coverage Δ Complexity Δ
src/Testing/TemplateTester.php 100% <100%> (ø) 12 <12> (?)
src/Testing/BotManTester.php 96% <100%> (+4.94%) 42 <5> (+1) ⬆️
src/Testing/ButtonTester.php 53.84% <53.84%> (ø) 13 <13> (?)
src/Testing/ElementButtonTester.php 58.69% <58.69%> (ø) 15 <15> (?)
src/Testing/QuestionTester.php 76.92% <76.92%> (ø) 13 <13> (?)
src/Testing/ElementTester.php 78.57% <78.57%> (ø) 14 <14> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf20a13...97fc8dd. Read the comment docs.

@KarlisJ
Copy link
Contributor Author

KarlisJ commented Oct 28, 2017

For some reason can not get StyleCI to pass. It want to remove and add the same line

@stefro
Copy link
Contributor

stefro commented Oct 3, 2019

This is a great idea! Can this please get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants