shortcode helper map height, using transients for geocoder#273
shortcode helper map height, using transients for geocoder#273hupe13 wants to merge 2 commits intobozdoz:masterfrom hupe13:master
Conversation
|
Thanks! I'll take a look |
|
I'd prefer to leave the transients in this pr: That pr stalled obviously as the original reporters stopped reviewing. I think switching options to transients is a breaking change. I realize it's ideal, but I wanted to plan out a good migration workflow. Again, the interest in the idea seems to have died off. Anyway, I think we leave transients for that pr/issue. If you don't mind removing those from this one. |
templates/shortcode-helper.php
Outdated
| $replace = array( | ||
| 'leaflet-map height=250 ', | ||
| 'leaflet-image height=250 ', | ||
| 'leaflet-wms height=250 ', |
There was a problem hiding this comment.
Might not be the best way to do this, but I guess it works. I would have thought we could set height via css and make the css "!important".
There was a problem hiding this comment.
I would have thought we could set height via css and make the css "!important".
Thank you for hint.
I remove this. I'm sorry, I didn't take #217 into account. |
This reverts commit 7cc79e9. revert last commit
|
2 participants
Hi Bozdoz,
I changed the shortcode helper page because reported bug.
I learned how to use transients. I have now applied this in the geocoder.
Please review.