fix(vm): increase max disk limit to 31

[JustasUmbrasas]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

We encountered an issue where the provider prevents adding more than 14 disk devices, while Proxmox VE currently supports up to 31 SCSI devices. This change increases the maximum disk limit from 14 to 31 to align with Proxmox VE's capabilities.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

[gemini-code-assist]

Summary of Changes

Hello @JustasUmbrasas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a discrepancy between the Terraform Proxmox provider and the Proxmox VE platform regarding the maximum number of attachable disk devices. Previously, the provider limited disk devices to 14, while Proxmox VE supports up to 31. This update adjusts the provider's schema to reflect the higher limit, enabling users to configure more disks per virtual machine.

Highlights

• Increased Disk Limit: The maximum number of disk devices allowed for a VM has been increased from 14 to 31.
• Proxmox VE Alignment: This change aligns the provider's capabilities with Proxmox VE, which supports up to 31 SCSI devices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request increases the maximum number of disks for a VM from 14 to 31, which aligns with the limit for SCSI devices in Proxmox VE. This is a valuable improvement that increases the provider's capabilities. The change is straightforward and correct. I have one minor suggestion to improve code maintainability.

[bpg]

Thanks for the fix @JustasUmbrasas!

LGTM! 🚀

[bpg]

@all-contributors please add @JustasUmbrasas for code

[allcontributors]

@bpg

I've put up a pull request to add @JustasUmbrasas! 🎉