CF-50 - Fixed - Two word google fonts not applying proplery#148
Open
yssambare12 wants to merge 1 commit intomasterfrom
Open
CF-50 - Fixed - Two word google fonts not applying proplery#148yssambare12 wants to merge 1 commit intomasterfrom
yssambare12 wants to merge 1 commit intomasterfrom
Conversation
Contributor
yssambare12
commented
Dec 19, 2025
yssambare12
commented
- CF-50 - Fixed - Two word google fonts not applying proplery
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where Google Fonts with two-word names were not applying correctly. The fix involves properly URL-encoding font file paths and changing how font names are extracted from the filesystem.
Key changes:
- Implemented proper URL encoding for font file paths by encoding each path segment individually
- Changed font name extraction to use folder names instead of parsing filenames
- Updated regex pattern for font file matching to be more strict and anchored
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/class-bcf-google-fonts-compatibility.php | Added URL encoding logic to properly encode font file paths with spaces or special characters in both update_fse_theme_json() and process_google_fonts_locally() methods |
| classes/class-bsf-custom-fonts-render.php | Updated URL encoding for font URLs, refined regex pattern for font file matching, and changed font name extraction to use folder names instead of filename parsing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.