Skip to content

Avoid destroying old player when video changes #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashe540 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid destroying old player when video changes #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a76335
Fixes #84, Avoids destroying old player when loading new video
ashe540 Feb 25, 2017
14d920a
Added support for reusing player for playlist, and included demo
ashe540 Feb 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/angular-youtube-embed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,15 @@ angular.module('youtube-embed', [])

function loadPlayer () {
if (scope.videoId || scope.playerVars.list) {
if (scope.player && typeof scope.player.destroy === 'function') {
scope.player.destroy();
if (scope.player) {
// player already exists do not replace instead use old player
if(scope.playerVars.list)
scope.player.loadPlaylist({ list: scope.playerVars.list, index: 0, suggestedQuality: "default"});
else
scope.player.loadVideoById(scope.videoId, 0, 'default');
} else {
scope.player = createPlayer();
}

scope.player = createPlayer();
}
};

Expand Down
10 changes: 10 additions & 0 deletions src/demo/advanced.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,16 @@ <h3>playlist</h3>
</div>
</div>

<div class="video-wrapper">
<h3>dynamic playlist id</h3>
<div class="embed-responsive embed-responsive-16by9">
<youtube-video class="embed-responsive-item" player-vars="dynamicPlaylist.vars"></youtube-video>
</div>
<div class="controls">
<button class="border-button toggle" ng-click="dynamicPlaylist.change()">change playlist</button>
</div>
</div>

<div class="video-wrapper">
<h3>dynamic video id</h3>
<div class="embed-responsive embed-responsive-16by9">
Expand Down
15 changes: 15 additions & 0 deletions src/demo/the.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,21 @@ myApp.controller('AdvancedCtrl', function ($scope) {
}
};

var firstPlaylist = 'PLISo53ifQd_iBPpybJay-SCAULHsoRicc';
var secondPlaylist = 'PLfKJ52Aom315E9RXmLkXeD3yS7rsIAgpQ'
$scope.dynamicPlaylist = {
vars: {
list: firstPlaylist
},
change: function () {
if ($scope.dynamicPlaylist.vars.list === firstPlaylist) {
$scope.dynamicPlaylist.vars.list = secondPlaylist;
} else {
$scope.dynamicPlaylist.vars.list = firstPlaylist;
}
}
};

var first = 'biZLZZFb468';
var second = 'lbVdyPZiOLM';
$scope.dynamic = {
Expand Down