Skip to content

Conversation

@alexthewilde
Copy link

See original issue #46
Fix adapted from #48

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do obj.hasOwnProperty(key) instead of the underscore dependency?

@brandly
Copy link
Owner

brandly commented Jul 18, 2015

i haven't pulled this down and tested things out yet, but this looks like the right approach! thanks a lot for the help 🌟

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this getIframe() check do?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your hard work here @brandly @alexthewilde. scope.player.cueVideoById === 'function' doesn't work for me. It causes the check for the preexisting player to fail when a valid player is instantiated. I think you might mean (typeof scope.player.cueVideoById === 'function') here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandly I believe this method returns the DOM node for the embedded iframe, maybe the intention is to make sure that it exists/is loaded?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getiframe function doesn't exists. I guess alex forget this one to include

@brandly
Copy link
Owner

brandly commented Aug 27, 2015

hey, @alexthewilde! take a look at my comments when you get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants