Add fuubar as formatting option#101
Open
tomasdundacek wants to merge 2 commits intobriandunn:masterfrom
Open
Conversation
7bffdaa to
dd9ca4a
Compare
52ee96d to
50f666b
Compare
Owner
|
I am interested in merging the addition of more notification types, and the formatter const lookup. Could the actual fubar adapter be a separate gem though, like |
Contributor
Author
|
@briandunn Thanks for the feedback, and yes - splitting the gem makes sense. I'm a little busy currently, but I will have a look at it in near future. |
358834f to
d7ccf3b
Compare
d7ccf3b to
2e5d73d
Compare
2cb660d to
ef7b13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @briandunn
Thanks for this brilliant gem! After reading the discussion in #87, I've been working on an option to allow other formatters to be used with this gem.
I have re-added the
-fCLI option, and eventually I would like to - in a different PR - create an option to have a.flatwarefile to store these options in the repo.Closes #87