Open
Conversation
Collaborator
palakchheda
commented
Feb 23, 2026
palakchheda
commented
- Add a configuration sample to deploy the Britive Broker on AWS ECS.
- Add a configuration sample to deploy the Britive broker on AWS EKS.
- Minor bug fixes and updates to README.
theborch
reviewed
Feb 23, 2026
| } | ||
| ], | ||
| "runtimePlatform": { | ||
| "cpuArchitecture": "X86_64", |
Collaborator
There was a problem hiding this comment.
we should make this an option between ARM and x86
Collaborator
Author
There was a problem hiding this comment.
updated with a new commit.
Configurable option for the architecture
theborch
reviewed
Feb 23, 2026
| # 2. Docker installed and running | ||
| # 3. kubectl installed and configured for your AKS cluster | ||
| # 4. AKS cluster running | ||
| # 5. britive-broker-1.0.0.jar in current directory |
Collaborator
Author
There was a problem hiding this comment.
updated with a new commit. configurable broker version
theborch
reviewed
Feb 23, 2026
| # Check for required files | ||
| log_info "Checking required files..." | ||
| if [ ! -f "britive-broker-1.0.0.jar" ]; then | ||
| log_error "britive-broker-1.0.0.jar not found in current directory" |
Collaborator
Author
There was a problem hiding this comment.
updated with a new commit. configurable broker version
theborch
reviewed
Feb 23, 2026
| && mkdir -p /var/run/sshd | ||
|
|
||
| # Copy Britive broker JAR | ||
| COPY britive-broker-1.0.0.jar /root/broker/ |
Collaborator
Author
There was a problem hiding this comment.
updated with a new commit. configurable broker version
theborch
reviewed
Feb 23, 2026
| - Create a new pool or select an existing one | ||
| - Copy the broker pool token | ||
|
|
||
| 6. **britive-broker-1.0.0.jar** file in this directory |
Collaborator
Author
There was a problem hiding this comment.
updated with a new commit. configurable broker version
theborch
reviewed
Feb 23, 2026
| 1. Copy the broker JAR file to this directory: | ||
|
|
||
| ```bash | ||
| cp /path/to/britive-broker-1.0.0.jar . |
Collaborator
Author
There was a problem hiding this comment.
updated with a new commit. configurable broker version
Replace hardcoded 1.0.0 with a BROKER_VERSION variable (default 2.0.0) across deploy.sh, Dockerfile, and README. Add --broker-version CLI flag to deploy.sh for runtime overrides without editing the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.