Use protoc mypy plugin to generate type stubs #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It's unclear why there are so many new files - maybe not everything in /src has to be included in git? |
Author
|
It looks like grpc-generated files are called |
Author
|
I removed the extra files, please check this is correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the developer experience much nicer for people using static type checkers (mypy of pylance). Addresses my comment in #54 .
Note that the makefile failed for me, I had to change
grpc_python_outtopython_grpc_out- not sure why? Maybe the name changed in a recent version of grpcio.