Merge Chad's changes from https://github.com/broccolijs/broccoli-filter/pull/28#8
Conversation
docs: fix typos
updates `async-disk-cache` to the latest version
Introduces md5-hex
|
Awesome! Will review and merge if good tonight. This plus @kellyselden fix of hash for dep may let us get babel/jshint persistent out this weekend! |
|
That's awesome! Let me know if there is anything I can do. |
Something more related to this, is getting broccoli-babel-transpiler using this pr |
|
@zackthehuman window support has landed for hash-for-dep ember-cli/hash-for-dep@335d69b |
|
@stefanpenner Shall I bump the version in package.json in this branch? |
|
Yup and remove the windows check. |
|
Bumping to 1.0.0 of hash-for-dep break the tests. On my mac this happens: I haven't tracked down the source of the issue yet, though. |
|
@zackthehuman It looks like my change may have broke OSX. @stefanpenner We may need to add OSX testing in Travis to prevent this. |
|
merged the two git histories (as best as possible) and merged manually. |
|
looking into the OSX issue now |
|
@zackthehuman & @kellyselden I am unable to replicate that issue on OSX @zackthehuman can you share reproduction steps? |
|
@stefanpenner & @kellyselden Maybe my OSX issue was a fluke. I just pulled the latest from master and that branch works fine. Previously the steps to reproduce were: |
lets assume a fluke, but keep in on our radar. Just a headsup, im working to fix the last bugs with using this and the broccoli-babel-transpiler then i'll move on the jshint and jscs. |
This merge's Chad's changes from broccolijs/broccoli-filter#28 into this plugin.