Skip to content

Capacitor#83

Open
planesandunicorns wants to merge 5 commits intobrody2consult:latestfrom
RosterBuster:capacitor
Open

Capacitor#83
planesandunicorns wants to merge 5 commits intobrody2consult:latestfrom
RosterBuster:capacitor

Conversation

@planesandunicorns
Copy link
Copy Markdown

Added 3 more paths to the iOS CopyFromResource function to allow copy of pre-populated database from Ionic Capacitor folder structures.
The database resides in this folder structure under Public->dbname or Public->assets->dbname.

@brody2consult
Copy link
Copy Markdown
Owner

Thanks @ronwondaal for the contribution. Some more explanation would be helpful. Also should this only apply to iOS?

@planesandunicorns
Copy link
Copy Markdown
Author

Thats a good question @brodybits, let me check that and if it also applies for Android I’ll put in another pull.

Ionic/Angular has an assets folder, and all files should be kept in this folder and are written to the www/assets folder on build. Therefor the addition of the www/assets folder. Capacitor no longer builds a ‘www’ folder but instead builds to a ‘public’ folder, so I added ‘public’ and ‘public/assets’ to the pre-populated paths that the plugin is checking.

@planesandunicorns
Copy link
Copy Markdown
Author

@brodybits, I cleaned up the iOS code and added code form android to check multiple paths. Same applied there, Capacitor now writes to public/assets.
It's checked but perhaps review the java code as i'm not much of an android programmer.

@HarelM
Copy link
Copy Markdown

HarelM commented Jul 26, 2022

What's the status of this PR?
I'm looking into migrating my app to capacitor and this seems like something that's probably needed...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants