Skip to content

Conversation

@MegaManSec
Copy link
Contributor

@MegaManSec MegaManSec commented Sep 5, 2025

Avoids an infinite loop DoS, if iterations can be controlled remotely.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would need test cases

@ljharb ljharb marked this pull request as draft September 23, 2025 06:01
@MegaManSec
Copy link
Contributor Author

I added a test case. I have no idea why the GitHub test/action is failing.

@MegaManSec
Copy link
Contributor Author

probably because of the branch also being named master. will make a new pr

@MegaManSec MegaManSec mentioned this pull request Sep 23, 2025
@MegaManSec
Copy link
Contributor Author

apparently not: #125

@ljharb
Copy link
Member

ljharb commented Sep 23, 2025

don't worry about the automatic rebase action.

@ljharb ljharb force-pushed the master branch 2 times, most recently from f209639 to a32fe22 Compare September 24, 2025 05:04
@ljharb ljharb changed the title Only allow finite iterations [Fix] only allow finite iterations Sep 24, 2025
@ljharb ljharb marked this pull request as ready for review September 24, 2025 05:05
@ljharb ljharb merged commit 67bd94d into browserify:master Sep 24, 2025
768 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants