4377: subtree benchmarks

[liam]

No description provided.

[github-actions]

🤖 Claude Code Review

Status: Complete

Summary

This PR adds comprehensive benchmark tests for subtree processing in the block assembly subsystem. The code includes benchmark comparisons, performance tests with varying subtree sizes (4 to 2048 items), granular overhead isolation benchmarks, and test helpers for generating blocks with subtrees.

Current Review

2 issues found - see detailed comment below

The test code is otherwise well-structured with clear documentation and follows project conventions.

[github-actions]

Issue 1: Incorrect transaction count (line 58)

The function CreateTestTransactionChainWithCount returns count-1 transactions (due to the loop using count-2 at line 41 in transactions.go). When calling with tc.txCount (5000), you get 4999 transactions, not 5000. This affects tx/sec calculations and subtree count assertions.

Issue 2: Unsafe testing.T usage in init() (line 212)

Using an uninitialized testing.T struct in package init() is unsafe. If CreateTestTransactionChainWithCount calls any t methods (like t.Fatalf), it will panic and prevent the package from loading.

Consider using hardcoded hashes, lazy initialization with sync.Once, or generating on first benchmark use.

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud