Skip to content

Conversation

@BraydenLangley
Copy link
Collaborator

@BraydenLangley BraydenLangley commented Jul 25, 2025

Description of Changes

  • Added Transaction.completeWithWallet method. This will make it easy to use a BRC-100 wallet to handle signing and transaction finalization.

Issues

Closes #315

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run npm run doc and npm run lint one final time before requesting a review
  • I have fixed all linter errors to ensure these changes are compliant with ts-standard
  • I have run npm version patch so that my changes will trigger a new version to be released when they are merged

@BraydenLangley BraydenLangley marked this pull request as draft July 25, 2025 21:13
Copy link
Collaborator

@tonesnotes tonesnotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have done this as a CreateActionArgs constructor? Allowing both the createAction and signAction flows to be supported?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glue finishWithWallet helpers

3 participants