netsync: allow sync with non localhost peers#2487
Merged
Roasbeef merged 2 commits intobtcsuite:masterfrom Mar 25, 2026
Merged
Conversation
In this commit, we remove the localhost-only restriction for sync peer candidates on regtest and simnet. Previously, isSyncCandidate rejected any regtest peer not on 127.0.0.1 or localhost, which prevented IBD when nodes run in Docker containers on bridge networks (e.g. 172.18.0.x). We also replace fragile pointer-equality checks against global chaincfg params with value-based Name field comparisons, and extend the exception to simnet since it has the same local-only usage pattern.
Add a test verifying that isSyncCandidate accepts peers from any address on regtest, including Docker bridge IPs, remote IPs, and IPv6.
Roasbeef
force-pushed
the
allow-ip-regtest
branch
from
f59c0a3 to
7f47da8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
In regtest mode, isSyncCandidate rejects any peer whose address is neither 127.0.0.1 nor localhost. This makes IBD impossible when nodes run in separate Docker containers, because each container receives a bridge network IP (e.g. 172.18.0.x). The sync manager never selects a sync peer, so the node remains at genesis regardless of how many peers are connected.