rpcclient: add GetTxOutProof{,Async} methods, speed up string parsing#2489
Open
guggero wants to merge 2 commits intobtcsuite:masterfrom
Open
rpcclient: add GetTxOutProof{,Async} methods, speed up string parsing#2489guggero wants to merge 2 commits intobtcsuite:masterfrom
guggero wants to merge 2 commits intobtcsuite:masterfrom
Conversation
Roasbeef
requested changes
Mar 24, 2026
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
Changes look good. Two main comments:
- Extract to helper function
- Tests for the expected output
This commit replaces the parsing of a JSON string with a simple prefix/suffix replacement of the quotes. That is much faster than allocating memory for a JSON parser. Where possible, we also directly decode the hex with a decoder to further reduce the number of allocations.
Collaborator
Author
|
Thanks for the review! I guess I was a bit lazy with this PR... Addressed your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new method to fetch transaction output inclusion proofs.
While observing this code and specifically the
GetBlockmethod on mainnet, I observed a lot of JSON-related memory allocations for basically turning"<hex_string>"into<hex_string>. So I changed those JSON parse calls with simple prefix/suffix string replacements, which should hopefully be much faster and require fewer allocations.