Skip to content

Conversation

@bbansalWolfPack
Copy link

Hello Brian

First of all thanks for the awesome tutorials, big fan.

While running the repo and going through tutorial, I found two issues for which I am creating this pull request.

  1. Console.log message in one component so thought to remove that
  2. In details component, when we make the api call to get details about a pet. I saw that some links returns 404 Error but the logic to handle them is missing. Even with 404, looks like api marks that promise a success because of which it shows in .then block where it fails as animal is undefined there. I added a catch block which sets loading to false and then the Error boundary takes over. Otherwise I was just seeing Loading on the screen which never gets to false.

Adding screenshot for the same.
Screen Shot 2020-08-16 at 10 29 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant