Lowercase string tokens while tokenizing#21
Open
TomTheBear wants to merge 1 commit intobtmills:masterfrom
Open
Lowercase string tokens while tokenizing#21TomTheBear wants to merge 1 commit intobtmills:masterfrom
TomTheBear wants to merge 1 commit intobtmills:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes all letters to lowercase while parsing. This simplyfies the matching later for special floats (
nan,NaN, ...) and functions (Sum,sum,SUM, ...).I'm not sure whether this rule is too general and we should delay the case switching. I needs to be done latest before checking the token type and calling
doFunc()