Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c79c8d1
Remove gen
lukasbindreiter Aug 28, 2025
e7be3c1
Split gencode into a publishable subpackage and a part only needed fo…
lukasbindreiter Aug 28, 2025
60a6f48
Make sed command work on Linux and Mac
lukasbindreiter Aug 28, 2025
4d5ddd6
Bootstrap using testpypi
lukasbindreiter Sep 9, 2025
df3b7d4
Separate makefile for protovalidate gencode
lukasbindreiter Sep 9, 2025
85111d7
Set up publishing workflow to test pypi
lukasbindreiter Sep 9, 2025
2126f50
Remove unnecessary buf files
lukasbindreiter Sep 9, 2025
72b0469
Fix sed command in makefile on unix
lukasbindreiter Sep 9, 2025
83d9c5f
Format test gencode
lukasbindreiter Sep 9, 2025
9959338
Revert formatting of autogenerated code
lukasbindreiter Sep 10, 2025
90bd390
Mark bufbuild-protovalidate-protocolbuffers as typed python package
lukasbindreiter Sep 10, 2025
cd56a52
Run ruff on unit tests
lukasbindreiter Sep 10, 2025
a5e83a4
Add ruff to bufbuild-protovalidate-protocolbuffers
lukasbindreiter Sep 10, 2025
6f0e935
Add script to sync bufbuild/protovalidate to pypi
lukasbindreiter Oct 20, 2025
bc8c294
Copy whole repo
lukasbindreiter Oct 20, 2025
476683b
Exclude generated files from ruff linting/formatting
lukasbindreiter Oct 21, 2025
f485ab7
Update checked in gencode to v1.0
lukasbindreiter Oct 21, 2025
6860688
Update conformance messages also to v1
lukasbindreiter Oct 21, 2025
66f8e6c
Debug ci issue
lukasbindreiter Oct 21, 2025
7de03b0
Use proper conformance binary
lukasbindreiter Oct 21, 2025
a8f49b7
Attempt to fix ci
lukasbindreiter Oct 21, 2025
e5a54ee
Relax python 3.12 version constraint again
lukasbindreiter Oct 21, 2025
3d98c73
Add __init__.py to test directory to mark pytest import root
lukasbindreiter Oct 21, 2025
5993067
remove init py for conformance tests
lukasbindreiter Oct 21, 2025
b8f8f36
Fix conformance test ci for python 3.12
lukasbindreiter Oct 22, 2025
20deb20
Fix linting
lukasbindreiter Oct 22, 2025
2b219aa
Scope generated test files to gen package rather than test.gen
lukasbindreiter Oct 22, 2025
6276a02
properly quote python version in github action
lukasbindreiter Oct 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@ name: CI
on:
push:
branches: [main]
tags: ['v*']
tags: ["v*"]
pull_request:
branches: [main]
schedule:
- cron: '15 22 * * *'
workflow_dispatch: {} # support manual runs
permissions:
contents: read
Expand All @@ -21,7 +19,7 @@ jobs:
resolution: ["highest", "lowest-direct"]
env:
# Shared env variables for all the tests
UV_RESOLUTION: '${{ matrix.resolution }}'
UV_RESOLUTION: "${{ matrix.resolution }}"
steps:
- name: Checkout code
uses: actions/checkout@v5
Expand All @@ -30,7 +28,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v6
with:
go-version: stable
go-version: "1.25.x"
cache: false
- uses: astral-sh/setup-uv@v7
with:
Expand Down
38 changes: 38 additions & 0 deletions .github/workflows/protovalidate-gencode-pypi-sync.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Push latest bufbuild-protovalidate-protocolbuffers to PyPI
on:
schedule:
- cron: "15 12 * * *"

permissions:
contents: read

jobs:
push-pypi:
name: Push latest bufbuild-protovalidate-protocolbuffers to PyPI
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- name: Checkout code
uses: actions/checkout@v5
with:
fetch-depth: 1
- name: Install Go
uses: actions/setup-go@v6
with:
go-version: stable
- uses: astral-sh/setup-uv@v6
with:
python-version: "3.10"
- name: Install dependencies
run: cd bufbuild-protovalidate-protocolbuffers && uv sync --frozen && make build && rm -rf dist
- name: Build and publish
run: cd bufbuild-protovalidate-protocolbuffers && uv run sync_to_pypi.py --pypi-url https://test.pypi.org
- name: Publish package distributions to TestPyPI
# authorization is done via OIDC, so no token needed
# Instead, we've set up a trusted publishing config for the pypi package, that maps to this repository and the
# protovalidate-gencode-pypi-sync workflow and maps it to the bufbuild-protovalidate-protocolbuffers package on pypi
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
packages-dir: bufbuild-protovalidate-protocolbuffers/dist
23 changes: 17 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ADD_LICENSE_HEADER := $(BIN)/license-header \
--license-type apache \
--copyright-holder "Buf Technologies, Inc." \
--year-range "2023-2025"
# This version should be kept in sync with the version in buf.yaml
# This version should be kept in sync with the version in buf.yaml and the bufbuild-protovalidate-protocolbuffers version in uv.lock
PROTOVALIDATE_VERSION ?= v1.0.0
# Version of the cel-spec that this implementation is conformant with
CEL_SPEC_VERSION ?= v0.24.0
Expand All @@ -34,13 +34,24 @@ clean: ## Delete intermediate build artifacts
git clean -Xdf

.PHONY: generate
generate: $(BIN)/buf $(BIN)/license-header ## Regenerate code and license headers
rm -rf gen
$(BIN)/buf generate buf.build/bufbuild/protovalidate:$(PROTOVALIDATE_VERSION)
generate: generate-protobuf-tests $(BIN)/license-header ## Regenerate code and license headers
$(ADD_LICENSE_HEADER)

.PHONY: generate-protobuf-tests
generate-protobuf-tests: $(BIN)/buf ## Regenerate protobuf gencode used in unit tests
rm -rf test/gen
# generate protovalidate-testing into test/gen/buf/validate
$(BIN)/buf generate buf.build/bufbuild/protovalidate-testing:$(PROTOVALIDATE_VERSION)

# generate cel-spec into test/gen/cel/expr
$(BIN)/buf generate buf.build/google/cel-spec:$(CEL_SPEC_VERSION) --exclude-path cel/expr/conformance/proto2 --exclude-path cel/expr/conformance/proto3
# we need to update the `from cel.expr` imports in those generated files to `from gen.cel.expr`
LC_ALL=C find test/gen/cel -type f -exec sed -i.bak 's/from cel.expr/from gen.cel.expr/g' {} + && find test/gen/cel -name '*.bak' -delete
# also update buf.validate.conformance imports
LC_ALL=C find test/gen/buf/validate/conformance -type f -exec sed -i.bak 's/from buf.validate.conformance/from gen.buf.validate.conformance/g' {} + && find test/gen/buf/validate/conformance -name '*.bak' -delete

# generate proto/tests/example/v1/validations.proto into test/gen/tests/example/v1
$(BIN)/buf generate
$(ADD_LICENSE_HEADER)

.PHONY: format
format: install $(BIN)/buf $(BIN)/license-header ## Format code
Expand All @@ -55,7 +66,7 @@ test: generate install $(TESTDATA_FILE) ## Run unit tests

.PHONY: conformance
conformance: $(BIN)/protovalidate-conformance generate install ## Run conformance tests
protovalidate-conformance $(CONFORMANCE_ARGS) uv run test/conformance/runner.py
$(BIN)/protovalidate-conformance $(CONFORMANCE_ARGS) uv run test/conformance/runner.py

.PHONY: lint
lint: install $(BIN)/buf ## Lint code
Expand Down
4 changes: 2 additions & 2 deletions buf.gen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ managed:
plugins:
# NOTE: v26.0 is the earliest version supporting protobuf==5.
- remote: buf.build/protocolbuffers/python:v26.0
out: gen
out: test/gen
- remote: buf.build/protocolbuffers/pyi:v26.0
out: gen
out: test/gen
1 change: 1 addition & 0 deletions bufbuild-protovalidate-protocolbuffers/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.tmp/bin
201 changes: 201 additions & 0 deletions bufbuild-protovalidate-protocolbuffers/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2023-2025 Buf Technologies, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
49 changes: 49 additions & 0 deletions bufbuild-protovalidate-protocolbuffers/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# See https://tech.davis-hansson.com/p/make/
SHELL := bash
.DELETE_ON_ERROR:
.SHELLFLAGS := -eu -o pipefail -c
.DEFAULT_GOAL := all
MAKEFLAGS += --warn-undefined-variables
MAKEFLAGS += --no-builtin-rules
MAKEFLAGS += --no-print-directory
BIN := .tmp/bin
export PATH := $(BIN):$(PATH)
export GOBIN := $(abspath $(BIN))
CONFORMANCE_ARGS ?= --strict_message --expected_failures=test/conformance/nonconforming.yaml --timeout 10s
ADD_LICENSE_HEADER := $(BIN)/license-header \
--license-type apache \
--copyright-holder "Buf Technologies, Inc." \
--year-range "2023-2025"
PROTOVALIDATE_VERSION ?= v1.0.0

.PHONY: help
help: ## Describe useful make targets
@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "%-15s %s\n", $$1, $$2}'

.PHONY: all
all: build

.PHONY: generate
generate: $(BIN)/buf $(BIN)/license-header ## Regenerate protobuf gencode for the bufbuild-protovalidate-protocolbuffers pypi package
rm -rf buf/validate/proto5
rm -rf buf/validate/proto6
# generate gencode for both proto5 and proto6 for buf.build/bufbuild/protovalidate
$(BIN)/buf generate buf.build/bufbuild/protovalidate:$(PROTOVALIDATE_VERSION)

# add license headers to the source files
$(ADD_LICENSE_HEADER)

# set the version of bufbuild-protovalidate-protocolbuffers to the used PROTOVALIDATE_VERSION
uv version $(PROTOVALIDATE_VERSION)

build: generate
uv build

$(BIN):
@mkdir -p $(BIN)

$(BIN)/buf: $(BIN) Makefile
go install github.com/bufbuild/buf/cmd/buf@latest

$(BIN)/license-header: $(BIN) Makefile
go install github.com/bufbuild/buf/private/pkg/licenseheader/cmd/license-header@latest
3 changes: 3 additions & 0 deletions bufbuild-protovalidate-protocolbuffers/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# bufbuild-protovalidate-protocolbuffers

Messages, enum types and stubs for [buf.build/bufbuild/protovalidate](https://buf.build/bufbuild/protovalidate) for python.
14 changes: 14 additions & 0 deletions bufbuild-protovalidate-protocolbuffers/buf.gen.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
version: v2
managed:
enabled: true
plugins:
# NOTE: v26.0 is the earliest version supporting protobuf==5.
- remote: buf.build/protocolbuffers/python:v26.0
out: buf/validate/proto5
- remote: buf.build/protocolbuffers/pyi:v26.0
out: buf/validate/proto5
# NOTE: v30.0 is the earliest version supporting protobuf==6.
- remote: buf.build/protocolbuffers/python:v30.0
out: buf/validate/proto6
- remote: buf.build/protocolbuffers/pyi:v30.0
out: buf/validate/proto6
Loading