-
Notifications
You must be signed in to change notification settings - Fork 2
add tests to confirm system metrics are present in app start and scene load spans #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richardelms
wants to merge
4
commits into
next
Choose a base branch
from
plat-15112-appStart-sceneLoad-Metrics
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -73,3 +73,66 @@ Scenario: App Start Clear Customisation | |||||||||||
| * the trace "Bugsnag-Span-Sampling" header equals "1:4" | ||||||||||||
| * the trace payload field "resourceSpans.0.scopeSpans.0.spans.3.name" equals "[AppStart/UnityRuntime]" | ||||||||||||
|
|
||||||||||||
| @android_only | ||||||||||||
| Scenario: App Start with metrics | ||||||||||||
| When I run the game in the "AppStartWithMetrics" state | ||||||||||||
| And I wait to receive 4 spans | ||||||||||||
|
|
||||||||||||
| # rendering metrics on the app-start span | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.total_frames" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.fps_average" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.fps_maximum" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.fps_minimum" greater than 0 | ||||||||||||
|
|
||||||||||||
| # memory metrics on the app-start span (arrayed samples) | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.memory.timestamps" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.system.memory.spaces.device.size" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.memory.spaces.device.used" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.system.memory.spaces.art.size" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.memory.spaces.art.used" with at least 5 elements | ||||||||||||
|
|
||||||||||||
| # CPU metrics on the app-start span | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.cpu_measures_timestamps" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.cpu_measures_total" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double array attribute "bugsnag.system.cpu_measures_total" containing valid percentages | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.cpu_measures_main_thread" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double array attribute "bugsnag.system.cpu_measures_main_thread" containing valid percentages | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double attribute "bugsnag.system.cpu_mean_total" that is a valid percentage | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double attribute "bugsnag.system.cpu_mean_main_thread" that is a valid percentage | ||||||||||||
|
|
||||||||||||
| # phase spans should also carry the memory metrics | ||||||||||||
| * the span named "[AppStartPhase/LoadAssemblies]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
| * the span named "[AppStartPhase/SplashScreen]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
| * the span named "[AppStartPhase/LoadFirstScene]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
|
|
||||||||||||
| @ios_only | ||||||||||||
| Scenario: App Start with metrics | ||||||||||||
| When I run the game in the "AppStartWithMetrics" state | ||||||||||||
| And I wait to receive 4 spans | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
|
|
||||||||||||
| # rendering metrics on the app-start span | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.total_frames" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.fps_average" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.fps_maximum" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.rendering.fps_minimum" greater than 0 | ||||||||||||
|
|
||||||||||||
| # memory metrics on the app-start span (arrayed samples) | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.memory.timestamps" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has integer attribute "bugsnag.system.memory.spaces.device.size" greater than 0 | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.memory.spaces.device.used" with at least 5 elements | ||||||||||||
|
|
||||||||||||
| # CPU metrics on the app-start span | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.cpu_measures_timestamps" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.cpu_measures_total" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double array attribute "bugsnag.system.cpu_measures_total" containing valid percentages | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has array attribute "bugsnag.system.cpu_measures_main_thread" with at least 5 elements | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double array attribute "bugsnag.system.cpu_measures_main_thread" containing valid percentages | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double attribute "bugsnag.system.cpu_mean_total" that is a valid percentage | ||||||||||||
| * the span named "[AppStart/UnityRuntime]" has double attribute "bugsnag.system.cpu_mean_main_thread" that is a valid percentage | ||||||||||||
|
|
||||||||||||
| # phase spans should also carry the memory metrics | ||||||||||||
| * the span named "[AppStartPhase/LoadAssemblies]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
| * the span named "[AppStartPhase/SplashScreen]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
| * the span named "[AppStartPhase/LoadFirstScene]" has integer attribute "bugsnag.device.physical_device_memory" greater than 0 | ||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the new step in Maze Runner to get better diagnostics if it fails to receive all the expected spans: