Increase unit test coverage to 93% across all modules#168
Open
Increase unit test coverage to 93% across all modules#168
Conversation
97 new tests covering PSBTIn/PSBTOut validate, parse, combine, finalize, and update paths, plus PSBT create, combine, and parse edge cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Black-format psbt.py and siphash.py (whitespace-only) - Fix flake8 issues in test_psbt_coverage.py (unused imports, variable, blank lines) - Scope pytest in run_tests.sh to buidl/test to avoid pexpect dependency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Three new test files covering op, siphash, merkleblock, witness, helper, descriptor, bcur, script, psbt_helper, tx, bech32, ecc, hd, taproot, compactfilter, and shamir modules. 282 new tests total. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jimmysong
changed the title
Collaborator
|
GitHub test running seems messed up in general (unrelated to this PR), but we need it to be passing for at least one configuration (slow on any OS is fine) in order to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buidl/testTest plan
run_tests.shpasses (black + pytest + flake8)python3.11 -m coverage report🤖 Generated with Claude Code