PJS001 conversion based units (IVS-680) #471
Conversation
(IVS-680)
aothms
left a comment
aothms
left a comment
There was a problem hiding this comment.
Really nice, but have a look at the two scenario suggestions. I think the schema still allows for some situations we need to check.
| if 'npath' in inspect.getargs(fn.__code__).args: | ||
| kwargs = kwargs | {'npath': current_path} | ||
| top_level_index = current_path[0] if current_path else None | ||
| max_index = len(current_path) - 1 |
There was a problem hiding this comment.
⚠
This is exactly related to my comment on #468
We should not be doing this, because in this way we're linking the wrong instance to the outcome presentation. We just really should make sure that the stack of values we build forms a proper tree.
There was a problem hiding this comment.
Something needs to be done because this feature file generates an IndexError as-is. The code tries to access element at index 1 when there is a single value in the list. I'll review your comment for clues. Maybe the Given statement needs to be revised.
There was a problem hiding this comment.
Ok, the IndexError makes sense in #468 based on the Given statement. I'm working through that now & will use lessons learned to resolve this PR.
Co-authored-by: Thomas Krijnen <t.krijnen@gmail.com>
Co-authored-by: Thomas Krijnen <t.krijnen@gmail.com>
Co-authored-by: Thomas Krijnen <t.krijnen@gmail.com>
…units' into IVS-680-PJS001-conversion-based-units
(IVS-680)
(IVS-680)
(IVS-680)
…erkin-rules into IVS-680-PJS001-conversion-based-units
| case "CONVERSIONFACTOR": | ||
| unit_name = inst.Name | ||
| if unit_name in accepted_names: | ||
| inst_factor = inst.ConversionFactor.ValueComponent.wrappedValue |
There was a problem hiding this comment.
Sorry, one more scenario for a next iteration
We could also check the corresponding measure type of the IfcValue-typed ValueComponent of IfcMeasureWithUnit here. Not sure if this is written constrained somewhere, sometimes you see IFCRATIOMEASURE sometimes you see the measure that corresponds to the Unit, such as IFCTIMEMEASURE
There was a problem hiding this comment.
Got it - I grabbed a link to this comment for future reference.
Co-authored-by: Thomas Krijnen <t.krijnen@gmail.com>
Co-authored-by: Thomas Krijnen <t.krijnen@gmail.com>
closes #107