Conversation
8f654ae to
3d5529f
Compare
failed test to be reported as passedfailed test to be reported as passed
3d5529f to
dad36ab
Compare
zhming0
approved these changes
Mar 27, 2025
Contributor
zhming0
left a comment
There was a problem hiding this comment.
Interesting! Looks good 👍🏿 . But since we cannot easily write a test for this, it's probably better to add more code comments for future travellers.
dad36ab to
e758659
Compare
e758659 to
30dde3a
Compare
Merged
failed test to be reported as passedfailed test to be reported as passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44 introduced a bug where failed tests are reported as
passed. This happened because I moved the execution collection (i.e. adding it to payload) from aftercallto afterteardownlifecycle. Apparently, thepytest_runtest_logreporthook that called afterteardownreturn areportobject that contains the outcome ofteardownprocess, not the outcome of the testcall. Therefore, when the test call result is failed, it is reported as passed because the teardown process was successful.This PR address the issue by fixing the hook ordering to be: