[release] 1.0.1rc1: more logs and defensive mechanism for test collection#49
Merged
[release] 1.0.1rc1: more logs and defensive mechanism for test collection#49
Conversation
niceking
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had one report of Test Result upload contains empty data. User claimed that this only started happening since
v1.0.0.I couldn't not reproduce the same issue (using the same pytest version) so I had to make a logical guess:
v0.2.0works means there is no problem in ourpytest_runtest_logreporthook (v1 introducedpytest_runtest_teardownhook to collect test, v0.2 relies solely onpytest_runtest_logreport).pytest_runtest_teardownfrom running.So I added lots of debug logging, user can opt-in to seeing them by setting env var
DEBUG=1.I also add some a defensive mechanism: another
pytest_runtest_logfinishhook hoping as a fallback option.